Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: outputs: dash0: Added Dash0 documentation #1532

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CodingFabian
Copy link

@CodingFabian CodingFabian commented Dec 17, 2024

Added documentation on how to send logs to dash0 based on the OpenTelemetry output plugin.

pipeline/outputs/dash0.md Show resolved Hide resolved
pipeline/outputs/dash0.md Show resolved Hide resolved
pipeline/outputs/dash0.md Show resolved Hide resolved
pipeline/outputs/dash0.md Outdated Show resolved Hide resolved
@CodingFabian CodingFabian changed the title Added Dash0 documentation pipeline: outputs: dash0: Added Dash0 documentation Dec 17, 2024
Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from technical perspective but will allow docs (@fluent/chronosphere-tech-writers ) to confirm the writing perspective.

Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions so we're using proper nouns properly =)

I'll go ahead and approve as well, if you'd update those two changes that'd be great.

And thanks for updating the spelling dictionary!


# Dash0

Stream logs to [Dash0](https://www.dash0.com) by utilizing the **opentelemetry** plugin to send data to the Dash0 log ingress.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Stream logs to [Dash0](https://www.dash0.com) by utilizing the **opentelemetry** plugin to send data to the Dash0 log ingress.
Stream logs to [Dash0](https://www.dash0.com) by utilizing the OpenTelemetry plugin to send data to the Dash0 log ingress.

It'd be nice to crosslink to the plugin, but not required.


### TLS / SSL

The opentelemetry output plugin supports TLS/SSL, for more details about the properties available and general configuration, please refer to the [TLS/SSL](../../administration/transport-security.md) section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The opentelemetry output plugin supports TLS/SSL, for more details about the properties available and general configuration, please refer to the [TLS/SSL](../../administration/transport-security.md) section.
The OpenTelemetry output plugin supports TLS/SSL. For more details about the properties available and general configuration, see [TLS/SSL](../../administration/transport-security.md).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's break any new sentences into new lines as well, makes it easier to review and comment on specific sentences then.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its how I copied it from another place. You want me to edit it there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants